fix(action): Don't pre-filter checked files#809
Merged
epage merged 1 commit intocrate-ci:masterfrom Aug 21, 2023
Merged
Conversation
This reverts commit fc7f517. This has two problems - This doesn't correctly handle spaces, likely needing crate-ci#708 - This overrides excludes, see crate-ci#347 This also has a weird cost/benefit balance because this requires enough repo history to do the analysis which takes time to pull down. Rather than waiting until the relevant changes are in to make this work, I'm pulling this out for now. Fixes crate-ci#806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fc7f517.
This has two problems
--file-list <PATH>to choose files to check #708This also has a weird cost/benefit balance because this requires enough repo history to do the analysis which takes time to pull down.
Rather than waiting until the relevant changes are in to make this work, I'm pulling this out for now.
Fixes #806