Skip to content

Conversation

epage
Copy link
Collaborator

@epage epage commented Sep 3, 2025

This is rustc/cargo's renderer and has all of the lessons of those,
including

  • Unicode support
  • Line wrapping / eliding of text to fit on screen

As part of this, we are now rendering file name typos like file
content typos.

image

This is a bit sloppy when it comes to terminal and unicode detection as it doesn't actually check the stream we are writing to.

This changed what we render the column number as when there are multi-byte characters present

Using Patchs for corrections is blocked on rust-lang/annotate-snippets-rs#300

This is rustc/cargo's renderer and has all of the lessons of those,
including
- Unicode support
- Line wrapping / eliding of text to fit on screen

As part of this, we are now rendering file name typos like file
content typos.
@coveralls
Copy link

coveralls commented Sep 3, 2025

Pull Request Test Coverage Report for Build 17444593752

Details

  • 0 of 59 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 19.943%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/typos-cli/src/bin/typos-cli/report.rs 0 59 0.0%
Totals Coverage Status
Change from base Build 17405587043: -0.5%
Covered Lines: 557
Relevant Lines: 2793

💛 - Coveralls

@epage epage merged commit 1bf1ed2 into crate-ci:master Sep 3, 2025
23 checks passed
@epage epage deleted the render branch September 3, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants