Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates-index feedback #326

Closed
kornelski opened this issue Aug 25, 2021 · 5 comments
Closed

crates-index feedback #326

kornelski opened this issue Aug 25, 2021 · 5 comments

Comments

@kornelski
Copy link

You're using the crates-index crate. I'm preparing to release 1.0 of the crate, and I'd like to finalize the API. Do you have any feedback or requests regarding the crate?

@epage
Copy link
Collaborator

epage commented Aug 25, 2021

Not really. Our use is pretty basic, so long as it works.

For another project of mine (verifying toml_edit), I'll need to iterate through every Cargo.toml. I'm assuming getting the Cargo.tomls is out of scope for crates-index but if you had any recommendations since I assume you've done similar, I'm all ears.

@kornelski
Copy link
Author

Thanks.

I get Cargo.toml the hard way, by downloading the crate file:

https://gitlab.com/crates.rs/crates.rs/-/blob/main/crates_io_client/src/lib_crates_io_client.rs#L77

and extracting it:

https://gitlab.com/crates.rs/crates.rs/-/blob/main/tarball/src/lib.rs

If you want to test the broken ones, look for Cargo.toml.orig.

@epage
Copy link
Collaborator

epage commented Aug 26, 2021

Looks like I need to retract my endorsement. Looks like master is dramatically different than 0.17 with there being no changelog to describe the changes, so I have no idea how well master works for my use cases

@epage epage reopened this Aug 26, 2021
@pksunkara
Copy link

Hmm... cargo-workspaces is in the same situation. Don't know how different master is.

@kornelski
Copy link
Author

@epage epage closed this as completed Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants