Check a file is opened

[raminfp]

No description provided.

[crash-utility]

Hello Ramin, Normally patches to the crash utility should be posted to the [email protected] mailing list for a general review, as I don't ever do a "git pull" directly of a github request. But this one is pretty obvious, so Ill apply it. For the release changelog entry, however, can you show exactly what happens during initialization? Does it fail quietly, cause a SIGSEGV, or just complain that the file is "not a supported file format"? Thanks, Dave

…

----- Original Message -----

You can view, comment on, or merge this pull request online at: #33 -- Commit Summary -- * Check a file is opened -- File Changes -- M s390_dump.c (5) -- Patch Links -- https://github.com/crash-utility/crash/pull/33.patch https://github.com/crash-utility/crash/pull/33.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #33

[raminfp]

Thanks Dave, just check if file format isn't exist,

…

On Mon, Apr 1, 2019, 17:40 crash-utility ***@***.***> wrote: Hello Ramin, Normally patches to the crash utility should be posted to the ***@***.*** mailing list for a general review, as I don't ever do a "git pull" directly of a github request. But this one is pretty obvious, so Ill apply it. For the release changelog entry, however, can you show exactly what happens during initialization? Does it fail quietly, cause a SIGSEGV, or just complain that the file is "not a supported file format"? Thanks, Dave ----- Original Message ----- > > You can view, comment on, or merge this pull request online at: > > #33 > > -- Commit Summary -- > > * Check a file is opened > > -- File Changes -- > > M s390_dump.c (5) > > -- Patch Links -- > > https://github.com/crash-utility/crash/pull/33.patch > https://github.com/crash-utility/crash/pull/33.diff > > -- > You are receiving this because you are subscribed to this thread. > Reply to this email directly or view it on GitHub: > #33 > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJlsZzldkblqMPlNFj1slDB1p--s-Utjks5vcgVfgaJpZM4cU9c4> .

[crash-utility]

----- Original Message -----

Thanks Dave, just check if file format isn't exist,

Ok, so for example, if I make the vmcore file unreadable, I see this cascade of error messages: $ crash vmlinux vmcore ... vmcore: ELF header read: Permission denied vmcore: ELF header read: Permission denied crash: vmcore: lseek: Invalid argument read_maps: unable to read header from vmcore, errno = 0 crash: sadump: cannot read dump device crash: sadump: cannot read partition header crash: vmw: Failed to read 'vmcore': [Error 13] Permission denied crash: vmcore: not a supported file format Usage: ... So as I understand it, with your patch, there will just be another line in addition to the above. Dave

…

On Mon, Apr 1, 2019, 17:40 crash-utility ***@***.***> wrote: > Hello Ramin, > > Normally patches to the crash utility should be posted to > the ***@***.*** mailing list for a general > review, as I don't ever do a "git pull" directly of a > github request. But this one is pretty obvious, so Ill > apply it. > > For the release changelog entry, however, can you show exactly > what happens during initialization? Does it fail quietly, cause > a SIGSEGV, or just complain that the file is "not a supported > file format"? > > Thanks, > Dave > > > ----- Original Message ----- > > > > You can view, comment on, or merge this pull request online at: > > > > #33 > > > > -- Commit Summary -- > > > > * Check a file is opened > > > > -- File Changes -- > > > > M s390_dump.c (5) > > > > -- Patch Links -- > > > > https://github.com/crash-utility/crash/pull/33.patch > > https://github.com/crash-utility/crash/pull/33.diff > > > > -- > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly or view it on GitHub: > > #33 > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#33 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AJlsZzldkblqMPlNFj1slDB1p--s-Utjks5vcgVfgaJpZM4cU9c4> > . > -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #33 (comment)

[crash-utility]

Note: I'm not going change is_390_dump() to exit, but rather I'm going to add its error message to the others, and return FALSE. Dave

…

----- Original Message -----

Closed #33. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #33 (comment)

[crash-utility]

----- Original Message -----

Ok, where is your commit?

3141801

…

On Mon, Apr 1, 2019, 20:14 crash-utility ***@***.***> wrote: > > Note: I'm not going change is_390_dump() to exit, but rather I'm going > to add its error message to the others, and return FALSE. > > Dave > > ----- Original Message ----- > > Closed #33. > > > > -- > > You are receiving this because you commented. > > Reply to this email directly or view it on GitHub: > > #33 (comment) > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <#33 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AJlsZ716imlm9tdnwheGQGrfTyCyV52bks5vcilngaJpZM4cU9c4> > . > -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #33 (comment)

[raminfp]

Cool, Thanks,

…

On Mon, Apr 1, 2019, 23:59 crash-utility ***@***.***> wrote: ----- Original Message ----- > Ok, where is your commit? 3141801 > > On Mon, Apr 1, 2019, 20:14 crash-utility ***@***.***> wrote: > > > > > Note: I'm not going change is_390_dump() to exit, but rather I'm going > > to add its error message to the others, and return FALSE. > > > > Dave > > > > ----- Original Message ----- > > > Closed #33. > > > > > > -- > > > You are receiving this because you commented. > > > Reply to this email directly or view it on GitHub: > > > #33 (comment) > > > > — > > You are receiving this because you modified the open/close state. > > Reply to this email directly, view it on GitHub > > <#33 (comment) >, > > or mute the thread > > < https://github.com/notifications/unsubscribe-auth/AJlsZ716imlm9tdnwheGQGrfTyCyV52bks5vcilngaJpZM4cU9c4 > > > . > > > > > -- > You are receiving this because you commented. > Reply to this email directly or view it on GitHub: > #33 (comment) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJlsZ4tJmJp8_LUPkVVNM5sq0PVLb4i_ks5vcl4DgaJpZM4cU9c4> .