Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import statement in fontawesome documentation #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kavanpancholi
Copy link

Currently in Font-Awesome documentation, it says

import {ThumbsUp} from 'vue-rate-it/glyphs/thumbs-up';

But there is not ThumbsUp object in vue-rate-it/glyphs/thumbs-up file.

And it says

created() {
    // register the icon
    this.thumbsUp = ThumbsUp
},
data() {
    return{
        thumbsUp: '' // declare the icon
    } 
} 

But it doesn't require to set in created function. It will work just fine if we set ThumbsUp in data.
Like this:

data() {
    return {
        thumbsUp: ThumbsUp // declare the icon
    } 
} 

So this PR fixes that with simpler documentation

@kavanpancholi kavanpancholi changed the title Fiix import statement in fontawesome documentation Fix import statement in fontawesome documentation Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant