Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier auto-formatting #1192

Merged
merged 3 commits into from
Sep 30, 2018
Merged

Conversation

starwed
Copy link
Member

@starwed starwed commented Sep 23, 2018

Prettier is a library for auto-formatting javascript code. I'd tried it in the past, but it used to mangle the formatting on certain files in the repo.

Seems like these bugs are now fixed, so

  • Add prettier as a dependency
  • Set up commit hooks that auto-format javascript files in the repo
  • Run the script on all existing files
  • Remove any jshint ignore line directives in favor of more explicitly scoped disabling. (Prettier was assuming it was ok to move the comments around, which didn't work for ignore line.)

I'm fine with all the default settings prettier uses, so I didn't add any special configs.

Fixes #951

@starwed starwed merged commit 3190eb0 into craftyjs:develop Sep 30, 2018
@starwed starwed deleted the prettier-crafty branch September 30, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce specific style guide
1 participant