Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and slightly improve comment in collision.js unit test #1171

Merged
merged 1 commit into from
Jan 21, 2018
+5 −3
Merged

Fix typo and slightly improve comment in collision.js unit test #1171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/unit/spatial/collision.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,12 @@
.attr({x: 0, y: 0, w: 2, h: 2});
var results = e1.hit('2D');
_.strictEqual(results.length, 1, "exactly one collision");
_.strictEqual(results[0].type, "MBR", "expecdted MBR collision type");
_.strictEqual(results[0].obj[0], e2[0], "Expected collision with e2");
_.strictEqual(results[0].type, "MBR", "expected MBR collision type");
_.strictEqual(results[0].obj[0], e2[0], "expected collision with e2");

// Move e2 such that it should be returned by the broadphase search, but should not be considered a hit
// Move e2 such that it should be returned by the broadphase search
// (i.e. it's in the same cell of the spatial hashmap)
// but doesn't actually overlap e1's MBR
e2.x=3;
var newResults = e1.hit('2D');
_.ok(!newResults, 0, "No collisions");
Expand Down