Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style improvements #1035

Merged
merged 4 commits into from
May 9, 2016
Merged

Code style improvements #1035

merged 4 commits into from
May 9, 2016

Conversation

mucaho
Copy link
Contributor

@mucaho mucaho commented May 8, 2016 •
edited
Loading

This PR improves code style by

  • converting indentation from tabs to spaces in graphics/gl-textures.js
  • adding configuration files which should help keep consistency
  • adds more lint checks, fixes part of Enforce specific style guide #951

mkucko added 3 commits May 8, 2016 18:23
@mkucko
Fix indentation of graphics/gl-textures.js
85e8c36 
Convert from tabs to spaces.
[skip ci]
@mkucko
Add gitattributes
2f4792a 
This setting will explicitly tell git to normalize line endings across
platforms.
[skip ci]
@mkucko
Add editorconfig
0e6fbed 
This configuration file will help keep a consistent basic code style
across editors.
Many plugins or native support in editors available.
[skip ci]
@mkucko
Improve jshint checks
cb0ba95 
Fix ignore configuration.
Lint javascript in html files.
Lint playgrounds.
Validate playgrounds and build directory.
@mucaho mucaho merged commit b77f693 into craftyjs:develop May 9, 2016
@mucaho mucaho deleted the misc4 branch May 9, 2016 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: no change kind: enhancement topic: meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mucaho @mkucko