Bnpl payment integration #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlicanAkkus
previously approved these changes
Nov 7, 2023
MasterSlave
reviewed
Nov 9, 2023
| @@ -202,6 +202,24 @@ public Object createApplePayMerchantSession(ApplePayMerchantSessionCreateRequest | |||
| applePayMerchantSessionCreateRequest, Object.class); | |||
| } | |||
|
|
|||
| public BnplPaymentOfferResponse offerBnplPayment(BnplPaymentOfferRequest bnplPaymentOfferRequest) { | |||
There was a problem hiding this comment.
retrieveBnplOffers yapalım mı?
MasterSlave
reviewed
Nov 9, 2023
|
|
||
| @Data | ||
| @SuperBuilder | ||
| public class ApmPaymentInitRequest { |
There was a problem hiding this comment.
InitApmPaymentRequest kullanılabilir. bunu silelim
MasterSlave
reviewed
Nov 9, 2023
| @Data | ||
| @SuperBuilder | ||
| @EqualsAndHashCode(callSuper = true) | ||
| public class BnplPaymentInitRequest extends ApmPaymentInitRequest { |
There was a problem hiding this comment.
InitApmPaymentRequest den extend edebilir
MasterSlave
reviewed
Nov 9, 2023
|
|
||
| @Data | ||
| @Builder | ||
| public class CreatePaymentItemRequest { |
MasterSlave
reviewed
Nov 9, 2023
|
|
||
| @Data | ||
| @Builder | ||
| public class ConvertedPaymentTxPayout { |
MasterSlave
reviewed
Nov 9, 2023
| import lombok.Data; | ||
|
|
||
| @Data | ||
| public class BnplPaymentInitResponse { |
There was a problem hiding this comment.
InitBnplPaymentResponse olarak değiştirelim
MasterSlave
reviewed
Nov 9, 2023
| import java.time.LocalDateTime; | ||
|
|
||
| @Data | ||
| public class PaymentTxResponse { |
MasterSlave
reviewed
Nov 9, 2023
|
|
||
|
|
||
| @Test | ||
| void init() { |
MasterSlave
reviewed
Nov 9, 2023
|
|
||
|
|
||
| @Test | ||
| void approve() { |
MasterSlave
reviewed
Nov 10, 2023
|
|
||
| @Data | ||
| @Builder | ||
| public class OfferBnplPaymentRequest { |
There was a problem hiding this comment.
Suggested change
| public class OfferBnplPaymentRequest { | |
| public class BnplPaymentOfferRequest { |
MasterSlave
reviewed
Nov 10, 2023
| import java.util.List; | ||
|
|
||
| @Data | ||
| public class OfferBnplPaymentResponse { |
There was a problem hiding this comment.
Suggested change
| public class OfferBnplPaymentResponse { | |
| public class BnplPaymentOfferResponse { |
MasterSlave
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.