Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isEmpty method #14

Closed
wants to merge 1 commit into from
Closed

add isEmpty method #14

wants to merge 1 commit into from

Conversation

i-just
Copy link

@i-just i-just commented Jul 18, 2024

Description

Adds the isEmpty() method to the HtmlFieldData class so that EmptyFieldConditionRule can work as expected.

There’s a related PR in the cms repo: craftcms/cms#15381.

Related issues

#267

@brandonkelly
Copy link
Member

Fields already have an isValueEmpty() method (which HtmlField already implements correctly), and EmptyFieldConditionRule will start calling that as of craftcms/cms@8600809.

@brandonkelly brandonkelly deleted the bugfix/267-isEmpty-method branch July 19, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants