Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announcement improvements #9748

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Announcement improvements #9748

merged 3 commits into from
Aug 21, 2021

Conversation

brandonkelly
Copy link
Member

Description

Improves the “What’s New” HUD in a couple ways:

  • Announcement heading and body messages are now lazy-translated (similar to Lazy translations for queue jobs #9745). So craft\services\Announcements::push() no longer accepts callables to be passed to $heading and $body.
  • The HUD now identifies where each announcement came from, by placing an icon and label above each announcement, rather than the timestamp.

The “What’s New” HUD, listing two previously-read announcements from Craft CMS, and one unread announcement from SEOmatic.

Related issues/discussions

@linear
Copy link

linear bot commented Aug 21, 2021

DEV-99 Announcement improvements

@brandonkelly brandonkelly merged commit a4fcecc into 4.0 Aug 21, 2021
@brandonkelly brandonkelly deleted the feature/dev-99-announcement-improvements branch August 21, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brandonkelly