Bugfix/17284 field names and conditionals #17361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you have
showFieldHandlesturned on, the conditional builder works as expected, but if you have it off and you have more than one field with the same name (but not handle), then you will only be able to see one field in the builder and will effectively be unable to target the other one. This happens in both v4 and v5, though it’s much easier to encounter in v5.et1) with an entry type that uses aplainTextfieldet2) with an entry type that usesplainTextandplainText2fieldset1section; one withplainTextset to “test 1” and the other to “test 2”et2section; one withplainTextset to “test 1” andplainText2set to “test 2”, and the other with “test 2” and “test 1”With this PR, you’ll see both “plain text” fields on the list, and you can use either one.
I know we discussed using tab names to make this clearer, but after playing with it, I think it makes things more complicated. We already show “duplicate” names in the View menu, so hopefully this will feel familiar.
Related issues
#17284