Fixed bug where element would disappear in a condition rule on reload. #16005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When making a condition rule that uses
BaseElementSelectConditionRule(like the "Related To" rule) the element would not show up after page reload. This is due to the element query looking for the$sitesService->getCurrentSite()->idby default.Fixed by changing the query to look for all sites. This also mimics the rule’s matching logic, which only matches on element ID.
CleanShot.2024-11-04.at.17.36.18.mp4
Related Issue
craftcms/commerce#3739