Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force template mode when loading _layouts/components/header-photo.twig #15487

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Force template mode when loading _layouts/components/header-photo.twig #15487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df79f22
Force template mode
timkelty Aug 6, 2024
096903a
Force CP
timkelty Aug 6, 2024
c2fffa0
Merge branch '5.x' into bugfix/header-photo-template-on-site
brandonkelly Sep 3, 2024
9c1943d
Just make sure it's a CP request
brandonkelly Sep 3, 2024
64a8d2b
Release note
brandonkelly Sep 3, 2024
0fd1336
Use $this->request
brandonkelly Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- Fixed a bug where Link fields didn’t allow URLs with TLDs longer than six characters.
- Fixed a bug where hard-deleting an element wasn’t hard-deleting any nested elements as well. ([#15645](https://github.com/craftcms/cms/pull/15645))
- Fixed a bug where it wasn’t possible to hard-delete nested elements from embedded element index views. ([#15645](https://github.com/craftcms/cms/pull/15645))
- Fixed an error that occurred when calling the `users/delete-user-photo` or `users/upload-user-photo` from the front end. ([#15487](https://github.com/craftcms/cms/pull/15487))

## 5.3.6 - 2024-08-26

Expand Down
2 changes: 1 addition & 1 deletion src/controllers/UsersController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2833,7 +2833,7 @@ private function _renderPhotoTemplate(User $user): Response
'photoId' => $user->photoId,
];

if ($user->getIsCurrent()) {
if ($user->getIsCurrent() && $this->request->getIsCpRequest()) {
$data['headerPhotoHtml'] = $view->renderTemplate('_layouts/components/header-photo.twig');
}

Expand Down
Loading