set secureHeaders property to prevent IP spoofing#15428
Open
nvdkemp wants to merge 1 commit intocraftcms:5.xfrom
Open
set secureHeaders property to prevent IP spoofing#15428nvdkemp wants to merge 1 commit intocraftcms:5.xfrom
nvdkemp wants to merge 1 commit intocraftcms:5.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the
craft\web\Requestclass the$ipHeadersproperty overwrites the default values set in the\yii\web\Requestclass. However the$secureHeadersproperty is not updated accordingly with the same headers.This oversight allows users to spoof their IP addresses. For instance, if someone sets a spoofed
Forwarded-Forheader to a random IP address, the methodCraft::$app->getRequest()->getUserIP()will return this spoofed IP address instead of the user's real IP. This happens because theForwarded-Forheader is not in the$secureHeadersproperty, making it vulnerable to manipulation.Tested with Craft version 4.8.7
Related issues