Core changes to make front-end 2FA possible#15343
Closed
brianjhanson wants to merge 7 commits into5.3from
Closed
Conversation
Contributor
Author
|
Converted back to a draft so I can work through setup from the front-end |
…rontend-login-with-mfa
…rontend-login-with-mfa
…rontend-login-with-mfa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum changes to make 2FA possible from the front-end. I had initially wanted to ship some javascript that would help with this, but the code currently powering the LoginForm and TotpForm very much expects the
Craftglobal to be present. I made a few attempts to untangle things but ultimately wanted to get this in so we can get our own implementation for console under our belts first.This makes your own implementation possible but not very easy. If you want to go down that path, there are a handful of things you'll have to implement. We have some ideas to make that easier, but they aren't included in this PR.