-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken JS on Cloud uploader when changing dirs #14542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
commented
Mar 6, 2024
timkelty
commented
Mar 6, 2024
timkelty
commented
Mar 6, 2024
timkelty
commented
Mar 6, 2024
timkelty
commented
Mar 6, 2024
timkelty
commented
Mar 6, 2024
timkelty
commented
Mar 6, 2024
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/pluginstore/dist/js/app.js # src/web/assets/pluginstore/dist/js/app.js.map
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #14439, a JS error was thrown when navigating directories.
This is because AssetIndex was calling
.fileupload()
, which can't be assumed, as only hte core Uploader uses the jquery uploader plugin.Changes
onSelectSource
fire beforeonSourcePathChange
to be less awkward.onSelectSource
fired first, we can be certain out uploader is created by the time we get toonSourcePathChange
fileupload
methods if the plugin wasn't instantiated (eg if uploading is disabled)replaceFileInput = false
, which is only needed for very old iframe uploading.History
Test cases