Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illuminate collection sort functions to respect sort_locale_string #14513

Merged

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Mar 1, 2024

Description

When updating the target language for the app, set the locale for string comparison to that target language. This will allow illuminate/collection sort functions to respect it when using SORT_LOCALE_STRING.

Before:
Screenshot 2024-03-01 at 15 24 16

After:
Screenshot 2024-03-01 at 15 23 59

Related issues

#14509

@i-just i-just changed the title enhances illuminate collection sort functions to respect sort_locale_string illuminate collection sort functions to respect sort_locale_string Mar 5, 2024
@i-just i-just marked this pull request as ready for review March 5, 2024 09:04
@i-just i-just requested a review from brandonkelly March 5, 2024 09:04
@brandonkelly brandonkelly changed the base branch from develop to 4.9 March 5, 2024 19:41
@brandonkelly brandonkelly merged commit 31a3a86 into 4.9 Mar 5, 2024
@brandonkelly brandonkelly deleted the bugfix/14509-collection-sort-functions-and-locales branch March 5, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants