Log info to console, don't log context by default #14434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
force-pushed
the
bugfix/log-info-to-console
branch
from
df536d2 to
37f774a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we moved to Monolog, we explicitly silenced logs below warnings when
CRAFT_STREAM_LOG=1AND the current request was a console request. This was done intentionally, so you didn't have console output mixed in with log output, but now that seems a bit short-sighted.This PR removes that condition, so logs will go to stderr/out as configured by
monologTargetConfig.level, or determined bydevModeby default. Additionally, it doesn't log request context by default for console requests, which was likely the annoyance that cause this to be this way in the first place.Related issues
Fixes #14280