Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use auto_position to position selectize dropdown #14160

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jan 18, 2024

Description

Position selectize dropdown above/below the field depending on how much space there’s left in the window.

The issue was originally fixed with the custom code in 4.4.6 as the auto_position plugin didn’t seem to do the trick back then. It looks like this broke again in 4.5.0, but now the auto_position plugin works as expected, so using it instead of the custom code.

Before screenshots are in the issue.

After screenshots:
Screenshot 2024-01-18 at 15 34 55
Screenshot 2024-01-18 at 15 43 50

Screenshot 2024-01-18 at 15 35 03 Screenshot 2024-01-18 at 15 35 18

Related issues

#14159

@i-just i-just requested a review from brandonkelly January 18, 2024 15:45
@brandonkelly brandonkelly changed the base branch from develop to 4.7 January 22, 2024 23:04
@brandonkelly brandonkelly merged commit 96b05f4 into 4.7 Jan 22, 2024
@brandonkelly brandonkelly deleted the bugfix/14159-selectize-dropdown-position branch January 22, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants