check if option has value differently #14143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-field-condition-rule
[ci skip]
brandonkelly
force-pushed
the
bugfix/14128-check-option-value-for-option-field-condition-rule
branch
from
0068f59 to
7f758f2
Compare
brandonkelly
deleted the
bugfix/14128-check-option-value-for-option-field-condition-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 2 of #14128.
When deciding which options to show in the options field condition rule, check if the value is not
nulland not an empty string instead of relying onempty(), so that an option with e.g. a value of0shows there too.Related issues
#14128