Admin table - move to page and paginated reordering #14051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/web/assets/admintable/dist/css/app.css # src/web/assets/admintable/dist/css/app.css.map # src/web/assets/admintable/dist/js/app.js # src/web/assets/admintable/dist/js/app.js.map
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, it is not possible to use drag-and-drop reordering on data being provided from a table data endpoint.
This PR adds this feature using a new action endpoint supplied in the options
paginatedReorderAction. It is a new endpoint to avoid any compatibility issues with the currentreorderActionused for tables with static table data.Along with this a
moveToPageActionhas been added to make things easy when moving an item from one page to another. There is also a new method in theAdminTablehelper class to help with the logic of making the data move (moveToPage()).Other improvements in this PR: