Fix error messages for custom uploaders #14029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR broke things for custom uploaders (eg Cloud), as
data
is undefined in that context.This is because we need to support the ancient blueimp/jQuery-File-Upload events, as well as standard JS events for alternate uploaders.
So, we need account for
data
being null, as well asevent
being an object with different props.To try and clarify this a bit, I added a default
null
value fordata
.@i-just I also used
data.files
rather than getting it from the FormData like you were, as that seemed more straightforward. If there is a reason not to use that let me know.Related issues