account for wildcards when checking accepts header #13802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
craft\web\Request->accepts()
, we should account for subtype wildcards in accepted content types.With changes in this PR:
getAcceptableContentTypes()
contains"application/*"
and you’re checkingaccepts('application/json')
, the results should betrue
getAcceptableContentTypes()
contains"application/json"
and you’re checkingaccepts('application/*')
, the results should befalse
getAcceptableContentTypes()
contains"application/json"
and you’re checkingaccepts('application/json')
, the results should betrue
Related issues
#13759