Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix block duplication - change when we set canonicalId #13670

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Sep 8, 2023

Description

When adding the owner element to a new site, don’t propagate matrix blocks to that new site if the field’s propagation method disallows it.

With the following setup:

  • (at least) 2 sites
  • matrix field with propagation: none (“Only save blocks to the site they were created in”)
  • section enabled for both sites with the above matrix field and propagation: custom (“Let each entry choose which sites it should be saved to”)

Create an entry on site 1, add at least one block to the matrix field and save.
Add the entry to site 2 and, without saving (while still editing a provisional draft), switch to the entry for site 2.
You shouldn’t see the matrix blocks from site 1 once you switch to site 2.

Related issues

https://app.frontapp.com/open/msg_ukaoki1?key=U6zkE_S6_ApMXn3ntPMwUxSLe0sUPsmY

@brandonkelly brandonkelly merged commit fccdd4b into develop Sep 11, 2023
@brandonkelly brandonkelly deleted the bugfix/matrix-duplicate-blocks-adjustment branch September 11, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants