Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI container for MonologTarget #13543

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Aug 10, 2023

No need to bother with an array return here, just instantiate with the DI container.
Fixes tests broken here: https://github.com/craftcms/cms/actions/runs/5797710403/job/15714040017

@timkelty timkelty changed the base branch from develop to 5.0 August 10, 2023 20:30
@timkelty timkelty force-pushed the return-monologtarget-as-config branch from 5bd16e5 to 818ad4c Compare August 10, 2023 20:31
@timkelty timkelty requested a review from brandonkelly August 10, 2023 20:32
@brandonkelly brandonkelly merged commit c528189 into 5.0 Aug 13, 2023
@brandonkelly brandonkelly deleted the return-monologtarget-as-config branch August 13, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants