Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespacing of pseudo-classes #13251

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

bencroker
Copy link
Contributor

@bencroker bencroker commented May 25, 2023

This (tiny) PR fixes the namespacing of pseudo-classes within <style> tags by adding a : to the list of possible characters that can follow a class name.

Before:

// Outputs `<style>.ns-a, .b:hover</style>`
Html::namespaceHtml('<style>.a, .b:hover</style>', 'ns', true))

After:

// Outputs `<style>.ns-a, .ns-b:hover</style>`
Html::namespaceHtml('<style>.a, .b:hover</style>', 'ns', true))

Discovered and reported via Discord by @maxstrebel.

@bencroker bencroker requested a review from a team as a code owner May 25, 2023 11:44
@brandonkelly brandonkelly merged commit 036c8e4 into craftcms:develop May 29, 2023
@brandonkelly
Copy link
Member

Thanks!

@brandonkelly
Copy link
Member

Craft 4.4.14 is out with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants