Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust element index spinner position so it's always visible (v4) #12994

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Mar 28, 2023

Description

Ensure that the loading spinner is centred in the viewport and, therefore, always visible.

This PR is just for Craft 4. Separate PR raised for Craft 3: #12993

Related issues

#12972

@i-just i-just requested a review from a team as a code owner March 28, 2023 09:21
@i-just i-just changed the title adjust element index spinner position so it's always visible adjust element index spinner position so it's always visible (v4) Mar 28, 2023
…on-v4

# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
[ci skip]
@brandonkelly brandonkelly self-requested a review as a code owner March 30, 2023 01:07
@brandonkelly brandonkelly merged commit 615bb31 into develop Mar 30, 2023
@brandonkelly brandonkelly deleted the bugfix/12972-element-index-spinner-position-v4 branch March 30, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants