ensure unique tab ids #12939
Merged
ensure unique tab ids #12939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Craft 4 allows you to have multiple tabs with the same name (in Craft 3, they were merged into one). I assume this is because of the conditions where you could have 2 tabs with the same name showing under different circumstances.
However, when no conditions are defined for the tabs, and you have at least 2 with the same name, only the first one will show when editing an element due to having the same ID.
This PR ensures tab ID is always unique, even if the name is not, by adding sort order (padded with zero), so what used to be
tab--contentnow becomes, e.g.tab02--content.Related issues
#12928