make sure we store changes in PC when catching #12850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
brandonkelly
deleted the
bugfix/12842-cant-delete-incomplete-entrified-sections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If during entrification we create a new section and then catch an error and exit, the changes are saved in the DB but not in the project config. This then causes a problem where you can’t delete such a section because it doesn’t exist in the PC.
This PR ensures that if we catch an exception and
$projectConfigChangedistrue, we store the changes in the PC.This error can be reproduced by, e.g. entrifying a category group and aborting when asked for the author data.
To be clear, the abort won’t trigger saving to the PC introduced in this PR, but it will reproduce the problem.
If you’ve encountered this problem, the only way to “fix” it is to rebuild the project config.
Related issues
#12842