Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure we store changes in PC when catching #12850

Merged

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Mar 9, 2023

Description

If during entrification we create a new section and then catch an error and exit, the changes are saved in the DB but not in the project config. This then causes a problem where you can’t delete such a section because it doesn’t exist in the PC.

This PR ensures that if we catch an exception and $projectConfigChanged is true, we store the changes in the PC.

This error can be reproduced by, e.g. entrifying a category group and aborting when asked for the author data.
To be clear, the abort won’t trigger saving to the PC introduced in this PR, but it will reproduce the problem.

If you’ve encountered this problem, the only way to “fix” it is to rebuild the project config.

Related issues

#12842

@i-just i-just requested a review from a team as a code owner March 9, 2023 15:47
@brandonkelly brandonkelly self-requested a review as a code owner March 9, 2023 19:30
@brandonkelly brandonkelly merged commit 37f3cec into develop Mar 9, 2023
@brandonkelly brandonkelly deleted the bugfix/12842-cant-delete-incomplete-entrified-sections branch March 9, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants