fix for pc apply: add site, change entry type, localise relations #12715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replication instructions: #12702 (comment)
What’s happening:
BaseRelationField->afterSave()
adds theLocalizeRelations
job to the queueentryType
(e.g. fromhasTitleField
:true
tofalse
) triggersSections->handleChangedEntryType()
Sections->_ensureSingleEntry()
, which triggers the element to be saved and propagatedRelations->saveRelations()
, which saves the existing relation that hadsourceSiteId
ofnull
tosourceSiteId
of the newly added siteLocalizeRelations
job is ready to do its job, there are no relations to localise cause the one it was supposed to localise now has thesourceSiteId
of the newly added siteThe fix:
Only attempt to save relations if we’re not applying PC changes to a Single.
Related issues
#12702