Matrix field handle validation #12501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, matrix handle length validation doesn't include the block type handle in the length, this makes it possible for you to create an overall field handle that's longer than the DB will allow. When this occurs things get left in a bad state, where some fields are saved and others fail. This fixes that issue by adding validation to matrix field handles to make sure they're not too long when including the block type handle in the field name. Fixes #12422
brianjhanson
force-pushed
the
bugfix/cms-12422-matrix-field-handle
branch
from
aff4a48 to
e664471
Compare
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, matrix handle length validation doesn't include the block type handle in the length, this makes it possible for you to create an overall field handle that's longer than the DB will allow. When this occurs things get left in a bad state, where some fields are saved and others fail.
This fixes that issue by adding validation to matrix field handles to make sure they're not too long when including the block type handle in the field name.
Fixes #12422