Allow array
as return type for prepareElementQuery
#12271
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with GQL queries where many of the resolvers return an array.
Which shown as per the below
cms/src/gql/base/ElementResolver.php
Lines 87 to 93 in b87d49b
If
prepareQuery()
doesn't return anElementQuery
then return it.Otherwise, you'll get the following error:
craft\\gql\\base\\ElementResolver::prepareElementQuery(): Return value must be of type craft\\elements\\db\\ElementQuery|Illuminate\\Support\\Collection, array returned
I suppose you could either enforce the resolvers to return a collection, or tighten up the
prepareQuery()
return types - take your pick!