Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y/update accordions #12189

Merged
merged 24 commits into from
Jan 5, 2023
Merged

A11y/update accordions #12189

merged 24 commits into from
Jan 5, 2023

Conversation

gcamacho079
Copy link
Contributor

@gcamacho079 gcamacho079 commented Oct 25, 2022 •
edited
Loading

Description

  • Modifies Utilities > Updates to use a new Accordion component, which is keyboard-accessible and follows the APG accordion pattern
  • Updates heading structure to eliminate multiple h1s on the page (although this creates another issue caused by h3s from the CHANGELOG that should be h4 in this context)
  • Cuts down on code repetition by creating a Garnish function for getting a user-preferred animation duration based on prefers-reduced-motion setting

Related issues

Resolves DEV-1031

@gcamacho079 gcamacho079 marked this pull request as ready for review October 25, 2022 21:18
@gcamacho079 gcamacho079 requested a review from a team as a code owner October 25, 2022 21:18
@gcamacho079 gcamacho079 reopened this Oct 26, 2022
@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label Nov 11, 2022
@brandonkelly brandonkelly changed the base branch from develop to 4.4 January 5, 2023 13:20
@brandonkelly
Merge branch '4.4' into a11y/update-accordions
3339c1f 
# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/garnish/dist/garnish.js
#	src/web/assets/garnish/dist/garnish.js.map
#	src/web/assets/updates/dist/UpdatesUtility.js.map
@brandonkelly
Border radius
60abd70
@brandonkelly
Increase release note heading levels
47fa9f0
@brandonkelly
Fix comment
52be444
@brandonkelly
Release note
c4c6442 
[ci skip]
@brandonkelly brandonkelly force-pushed the a11y/update-accordions branch from 280947f to c4c6442 Compare January 5, 2023 22:47
@brandonkelly brandonkelly merged commit 1945e8a into 4.4 Jan 5, 2023
@brandonkelly brandonkelly deleted the a11y/update-accordions branch January 5, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accessibility 👤 features related to accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcamacho079 @brandonkelly