money field to distinguish between zero and null #12132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
brandonkelly
deleted the
bugfix/12122-money-field-distinguish-zero-and-null
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Money field was behaving as if it was not able to store zero as value. If zero or null were returned from the DB, money field was showing as empty in both cases.
Updated twig template to not treat zero value as no value.
Updated mask behaviour to make it clear that when the
0.00placeholder shows, when you click into an empty field, it's only a placeholder and not an actual value. User actually has to type in0to specify a zero value.Related issues
#12122