Prevent TypeError due to null values in new elements
#12077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a rule that extends
BaseTextConditionRuleto a field layout element causes the edit pages to throw aTypeErrorafter creation, due to titles and field values being initialized asnull.This adds checks to the three problematic operators (
BaseTextConditionRule::OPERATOR_BEGINS_WITH,BaseTextConditionRule::OPERATOR_ENDS_WITH, andBaseTextConditionRule::OPERATOR_CONTAINS) to ensure the values are strings, prior to calling the appropriateStringHelpermethods.Edit: Today I'm feeling less confident about the
is_string()check… initially, I thought just an emptiness check would be fine, butnulland''are still different things, as far as the database is concerned. 😩 Empty strings do behave as expected.