Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value for allowLineBreaks #12004

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Sep 23, 2022

Description

This adds a default (production-ready) value for MonologTarget::allowLineBreaks.
It appears to just have been an oversight – the only required constructor param should should name.

It shouldn't be breaking, as anyone instantiating MonologTarget would have had to be explicitly setting it.

@timkelty timkelty requested a review from a team as a code owner September 23, 2022 19:20
@brandonkelly brandonkelly self-requested a review as a code owner October 5, 2022 13:13
@brandonkelly brandonkelly merged commit 36fb3d1 into develop Oct 5, 2022
@brandonkelly brandonkelly deleted the logging-default-line-breaks branch October 5, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants