Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure primary action menu doesn't fall offscreen on small viewports #11963

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

gcamacho079
Copy link
Contributor

Description

Makes .btngroup span width of screen on smaller viewports, ensuring right alignment doesn't cause an overflow
Screenshot of category index screen on a small viewport; the 'New category' button stretches so that the disclosure trigger is aligned with the right side of the screen

Related issues

…mall screens to ensure disclosure in action buttons container does not fall offscreen
@linear
Copy link

linear bot commented Sep 16, 2022

DEV-959 At 320px width, primary action menu options and Actions menu options overflow screen

Page Area:

Entries and categories screen - button.btn.submit.menubtn.btngroup-btn-last and Action menu that appears on element select

Issue Description:

On Categories screen, both action menu and primary action menu are affected. On Entries screen, only the primary action menu is affected.

Action:

Ensure menus aren't clipped by edges of screen, by centering them in the viewport if they might overflow

Screenshot/Code Snippet:

Screen Shot 2022-08-08 at 11.30.30 AM.png

Resolves CMS-259

@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label Sep 21, 2022
# Conflicts:
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
#	src/web/assets/pluginstore/dist/css/app.css

[ci skip]
[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants