Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DateTime import in craft\imagetransforms\ImageTransformer() #11863

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Fix DateTime import in craft\imagetransforms\ImageTransformer() #11863

merged 4 commits into from
Sep 5, 2022

Conversation

brianjhanson
Copy link
Contributor

Description

In the course of investigating #11852 I noticed that dateIndexed was always getting set to null instead of the date, despite trying to set it when creating the model. I'm not 100% sure this is related to the issue, but it feels like it could be because we use dateIndexed in a handful of ways in validateTrnasformIndexResult().

Related issues

#11852

@brianjhanson brianjhanson requested a review from a team as a code owner September 1, 2022 17:32
@brandonkelly brandonkelly self-requested a review as a code owner September 5, 2022 13:25
@brandonkelly brandonkelly merged commit 25efc72 into develop Sep 5, 2022
@brandonkelly brandonkelly deleted the bugfix/correct-datetime-import branch September 5, 2022 13:25
@brandonkelly brandonkelly mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonkelly brandonkelly Awaiting requested review from brandonkelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianjhanson @brandonkelly