Update resize handle #11727
Merged
Update resize handle #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcamacho079
requested review from
benjamindavid,
nfourtythree,
brandonkelly and
a team
as code owners
DEV-489 Modal resize handle does not meet minimum contrast requirements for UI components
Where: Modal resize handle The handle image color has a contrast ratio of only 1.44:1 (#BDC6D0 on #E4EDF6) against the modal background The resize handle image should be darkened to something like #7284BB in order to meet a 3:1 ratio Resolves CMS-139 |
# Conflicts: # src/web/assets/admintable/dist/css/app.css # src/web/assets/admintable/dist/js/app.js # src/web/assets/admintable/dist/js/app.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/garnish/dist/garnish.js # src/web/assets/garnish/dist/garnish.js.map # src/web/assets/pluginstore/dist/css/app.css # src/web/assets/pluginstore/dist/css/app.css.map
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve contrast of resize handle by using SVG with inherited
--ui-control-colorpath fill color. New handle has a contrast ratio of 4.96:1 versus the previous 1.44:1Resolves DEV-489