Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard accessibility improvements #11703

Merged
merged 15 commits into from
Aug 12, 2022
Merged

Dashboard accessibility improvements #11703

merged 15 commits into from
Aug 12, 2022

Conversation

gcamacho079
Copy link
Contributor

@gcamacho079 gcamacho079 commented Jul 26, 2022

Description

Resolves all issues referenced in #7301, except for focus order

  • Adds macros for external links and external link icons
  • Sets support icons to aria-hidden="true"
  • Adds close button to support forms
  • Adds visible labels to text area, and adds a header to clarify the support action
  • Removes IDs from icons in dashboard widget manager (Resolves DEV-662)

@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label Jul 26, 2022
@gcamacho079 gcamacho079 requested a review from a team as a code owner July 26, 2022 19:46
@linear
Copy link

linear bot commented Jul 26, 2022

DEV-662 Icons in widget settings table have duplicate IDs

Page Area:

Dashboard - widget settings HUD

Issue Description:

The clock, feed, and drafts icons in the widget settings menu cause duplicate IDs on the page

Action:

Remove or namespace IDs for each of these SVGs to prevent duplicates

Screenshot/Code Snippet:

Screen Shot 2022-05-23 at 2.31.48 PM.png

Screen Shot 2022-05-23 at 2.31.44 PM.png

Resolves CMS-233

@brandonkelly brandonkelly changed the base branch from 4.2 to 4.3 July 27, 2022 22:48
# Conflicts:
#	src/web/assets/vue/dist/vue.js
#	src/web/assets/vue/dist/vue.js.LICENSE.txt
[ci skip]
@brandonkelly brandonkelly merged commit 7e1d61b into 4.3 Aug 12, 2022
@brandonkelly brandonkelly deleted the a11y/improvements branch August 12, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants