-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard accessibility improvements #11703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… purpose of textarea
DEV-662 Icons in widget settings table have duplicate IDs
Page Area: Dashboard - widget settings HUD Issue Description: The clock, feed, and drafts icons in the widget settings menu cause duplicate IDs on the page Action: Remove or namespace IDs for each of these SVGs to prevent duplicates Screenshot/Code Snippet: Screen Shot 2022-05-23 at 2.31.48 PM.png Screen Shot 2022-05-23 at 2.31.44 PM.png Resolves CMS-233 |
gcamacho079
commented
Jul 26, 2022
# Conflicts: # src/web/assets/vue/dist/vue.js # src/web/assets/vue/dist/vue.js.LICENSE.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves all issues referenced in #7301, except for focus order
aria-hidden="true"