Fix instance of color-only error indication on elements #11610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcamacho079
requested review from
benjamindavid,
nfourtythree and
a team
as code owners
DEV-687 When an image asset has a validation error, it's indicated via red text inside the entry form
Page Area: Entry form Issue Description: When a field inside a selected element has a validation error, the validation error is only indicated on the element via the red text color. Action: Add an error symbol or other indicator that doesn't rely on the use of color alone Screenshot/Code Snippet: Screenshot showing the selected asset (inside the image matrix block, not the slideout) only indicates there's an error using red text. Screen Shot 2022-06-02 at 2.10.16 PM.png Resolves CMS-234 |
# Conflicts: # src/web/assets/admintable/dist/css/app.css # src/web/assets/admintable/dist/css/app.css.map # src/web/assets/admintable/dist/js/app.js # src/web/assets/admintable/dist/js/app.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/pluginstore/dist/css/app.css.map
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves DEV-687