A11y/use fieldsets for prefs #11534
A11y/use fieldsets for prefs #11534
Conversation
DEV-333 Accessibility and Development headings should use fieldset/legend
Because controls are visually grouped, they should be a part of a fieldset element. For each group of checkboxes, the heading/label should use a legend element, and the wrapping element should use a fieldset element Resolves CMS-047 |
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| {% set fieldsetAttributes = { | |||
| class: ['checkbox-group'], | |||
| role: 'presentation', | |||
There was a problem hiding this comment.
@brandonkelly I added this for both the checkboxGroup and the radioGroup as I wasn't sure if changing the fieldset element to a div would be problematic; if not let me know and I can modify the tag itself.
There was a problem hiding this comment.
Probably safe to just change the tag.
# Conflicts: # src/templates/users/_edit.twig
|
@gcamacho079 Just merged |
…Group, add extra heading to preferences tab for consistency between sections
gcamacho079
requested review from
benjamindavid and
nfourtythree
as code owners
|
@brandonkelly just tested and made the following changes:
|
|
👍🏻 Replaced “Location” with “General”, and also split the Debug Toolbar-related development settings into their own checkbox group.
|
Description
Use fieldsets for accessibility and dev preferences (Resolves DEV-333).
Also fixes an issue where
fieldsetelements are nested insidefieldsetelements for both radio groups and checkbox groups.Related issues