Make keyed data accessible with ActiveFixture
#11445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/ActiveFixture.php
Outdated
| @@ -63,7 +63,8 @@ public function load(): void | |||
| throw new InvalidArgumentException('Unable to save fixture data'); | |||
| } | |||
|
|
|||
| $this->ids[] = $arInstance->id; | |||
| $this->data[$key] = array_merge($row, $arInstance->toArray()); | |||
There was a problem hiding this comment.
Should this be just $this->data[$key] = $arInstance; ?
There was a problem hiding this comment.
Yes probably, I think I got a bit tunnel-visioned trying to keep it close to the base method in Yii's `ActiveFixture class: https://github.com/yiisoft/yii2/blob/master/framework/test/ActiveFixture.php#L86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Craft's implementation of
ActiveFixtureoverrides theloadmethod. In doing so it is not populating thedataproperty during the process.This causes an issue as it means if you are using this class you are unable to retrieve the data from the fixture. Using
$this->tester->grabFixture('my-fixture', 'alias-key')returnsnull. This PR fixes that issue and will now return the data for that fixture.This all gives great flexibility when writing tests that use fixtures as you will be able to write assertions based on the actual data without having to do any extra queries.