Prevent hidden folders in volumes from being indexed #11384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much @mmikkel! |
brandonkelly
added a commit
that referenced
this pull request
Jun 7, 2022
|
Craft 4.0.5 is out now with that fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't know if this is the way you want to go with it, but if merged this PR should resolve #11362.
This PR changes the way the Asset Indexes utility compiles the list of files to index, by making the
AssetIndexer::startIndexingSession()method pull the indexing file list via theAssetIndexer::getIndexListOnVolume()method, instead of getting it directly from the volume's filesystem instance.This makes sure that any files in folders beginning with an underscore are completely ignored during the indexing process, which is consistent with how asset indexing currently works in 4.x via CLI, as well as how indexing via the Asset Indexes utility worked in 3.x.
This PR also fixes a wrongly typed exception handler in the AssetIndexer service.
Related issues
#11362