Fix bug blocking keyboard users from accessing video controls #11371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…focusable element inside
gcamacho079
requested review from
benjamindavid,
nfourtythree and
a team
as code owners
DEV-413 Video controls are not operable by keyboard users
Video controls in HTML5 video player are not able to be focused or operated by keyboard users Make controls focusable and have visible focus indicators Screen Shot 2022-03-31 at 10.01.03 AM.png Resolves CMS-090 |
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
brandonkelly
requested changes
Jun 8, 2022
…ure jQuery object not empty
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
brandonkelly
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds bumper buttons to preview modals to address focus trap bug caused by video controls being in the Shadow DOM (Resolves DEV-413)
In addition:
iframeandvideoare the only ones present in a modal container0instead ofautosetFocusWithinfunction to set focus on modal container if no focusable elements are inside