Error: Return value of craft\helpers\App::phpConfigValueInBytes() must be of the type integer, float returned

[BrandonJamesBorders]

Description

Installing plugins from the CMS no longer work.

Steps to reproduce

1. Go to the plugin store page within Craft CMS install.
2. Find a plugin to install and hit click "Try" or "Install"
3. See error message.

Additional info

• Craft version: 3.1.4
• PHP version: 7.2.8
• Database driver & version: MySQL 5.5.5
• Operating System: Windows 10.0.17763.0

[BrandonJamesBorders]

If I'm assuming correctly that this is related to 3.1.4 and checking of php memory_limit, this is what I get when I run the phpConfigValueInBytes function:

$var = 'memory_limit';
$value = trim(ini_get($var));
$unit = strtolower(substr($value, -1, 1));
$value = (int)$value;
switch ($unit) {
    case 'g':
        $value *= 1024;
    // no break (cumulative multiplier)
    case 'm':
        $value *= 1024;
    // no break (cumulative multiplier)
    case 'k':
        $value *= 1024;
}
var_dump($value)

$value returns float(2147483648)

If I dump out $value * 1024 I get int(2097152), but for somereason when that happens inside the switch statement it converts to a float.

[BrandonJamesBorders]

So this is a 32-bit PHP error combined with having a memory limit >= 2048M as the result would be 2,147,483,648 and the max integer size on 32-bit PHP is 2,147,483,647.

[BrandonJamesBorders]

#3721

Proposed fix to change expected response as a float, which suppor

[brandonkelly]

Thanks for the bug report and investigating it! Fixed for the next release. In the meantime, you can get around it by changing your memory_limit config setting to -1.