Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the error text styling #2885

Closed
brandonkelly opened this issue May 15, 2018 · 2 comments
Closed

Change the error text styling #2885

brandonkelly opened this issue May 15, 2018 · 2 comments
Labels
accessibility 👤 features related to accessibility enhancement improvements to existing features

Comments

@brandonkelly
Copy link
Member

There is a form of color blindness where our red error text color is indistinguishable from normal text, making it impossible to spot the errors on a page.
@brandonkelly brandonkelly added enhancement improvements to existing features accessibility 👤 features related to accessibility labels May 15, 2018
brandonkelly added a commit that referenced this issue May 15, 2018
@brandonkelly
Make error text orange instead of red
3ba2f3a 
resolves #2885
brandonkelly added a commit to craftcms/sass that referenced this issue May 15, 2018
@brandonkelly
Change error color to orange
553f0e7 
craftcms/cms#2885
@lukeyouell
Copy link

@brandonkelly on the topic of accessibility, having white text over the orange background in the error banner fails the colour contrast check:

image

brandonkelly added a commit to craftcms/sass that referenced this issue May 22, 2018
@brandonkelly
Improve error/warning/success colors
4181b9c 
fixes craftcms/cms#2885
brandonkelly added a commit that referenced this issue May 22, 2018
@brandonkelly
updated the sass mixin
29691a3 
fixes #2885
@brandonkelly
Copy link
Member Author

@lukeyouell Done :)

brandonkelly added a commit that referenced this issue May 22, 2018
@brandonkelly
Color contrast improvements
3ba0583 
resolves #2885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility 👤 features related to accessibility enhancement improvements to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonkelly @lukeyouell