Skip to content

Commit

Permalink
Fixed #15415
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonkelly committed Jul 26, 2024
1 parent 4a0149f commit 503c096
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Fixed a bug where element index result counts weren’t getting updated when the element list was refreshed but pagination was preserved. ([#15367](https://github.com/craftcms/cms/issues/15367))
- Fixed a PHP error that occurred when making a field layout component conditional on a Time or CKEditor field. ([craftcms/ckeditor#267](https://github.com/craftcms/ckeditor/issues/267))
- Fixed an error that occurred when editing a user via a slideout, if the current user didn’t have permission to edit the primary site. ([#15408](https://github.com/craftcms/cms/issues/15408))
- Fixed a bug where editable tables with single-select checkbox columns weren’t deselecting the selected option automatically. ([#15415](https://github.com/craftcms/cms/issues/15415))

## 4.10.6 - 2024-07-16

Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/cp.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/cp.js.map

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions src/web/assets/cp/src/js/EditableTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,13 @@ Craft.EditableTable = Garnish.Base.extend(
this.updateAddRowButton();
this.addListener(this.$addRowBtn, 'activate', 'addRow');

// don't allow lazyInitRows if any of the columns are radio checkboxes
this.settings.lazyInitRows =
this.settings.lazyInitRows &&
!Object.entries(this.columns).some(
([colId, col]) => col.type === 'checkbox' && col.radioMode
);

if (this.settings.lazyInitRows) {
// Lazily create the row objects
this.addListener(
Expand Down

0 comments on commit 503c096

Please sign in to comment.