Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove pkg_resources #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

BenjaminHalko
Copy link

pkg_resources is depreciated in Python 3.12. This PR replaces it with importlib.resources.

@craffel
Copy link
Owner

craffel commented Feb 27, 2024

Thanks, but pkg_resources is still used to get the default SF2 path:

synthesizer = pkg_resources.resource_filename(__name__, DEFAULT_SF2)
That would need to be fixed (and we'd need to verify that, after applying this PR, the library could be installed with the default SF2 in place and usable by the fluidsynth code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants